主页 / user-21639868

bnthsrikanth's questions

Martin Hope
bnthsrikanth
Asked: 2023-11-15 00:36:47 +0800 CST
  • 6

我有一个 Salesforce Apex REST 服务 (LeadService)，它以 JSON 格式处理传入的潜在客户。此外，我正在寻找增强错误处理并使代码更易于维护的方法。提供建议或改进，以优化批量更新插入流程并增强整体代码结构

@RestResource(urlMapping='/api/lead')
global class Service {
@HttpPost
global static string createdata(){
   
    RestResponse res = Restcontext.response;
    String requestBody = RestContext.request.requestBody.toString();
    try {   
        // Deserialize JSON data into a list of LeadDataDeserializer objects
        List<LeadDataDeserializer> externalLeads = (List<LeadDataDeserializer>)
            JSON.deserializeStrict(requestBody, List<LeadDataDeserializer>.class);            
        // Transform LeadDataDeserializer objects into Lead data
        List<Lead> students = new List<Lead>();
        for(LeadDataDeserializer info : externalLeads) {
            Lead t_leads = setLeadFields(info);
            t_leads.company='Test Company';
            students.add(t_leads);
        }
        if(students.isEmpty()){
            res.statusCode=400;
            return 'Empty list';
            
           
        }
        else{
            List<Response> responseretn=new List<Response>();
            Database.UpsertResult[] srList = Database.upsert(students, Lead.External_Id__c, false);
            // Process upsert results if needed
            Integer i=0;
            for(Database.UpsertResult upResult:srList){
                if(upResult.isSuccess()){
                    responseretn.add(new Response(upResult.getId(),true,students[i].MobilePhone));
                }
                else{
                    System.debug(upResult.getErrors());
                    responseretn.add(new Response(upResult.getId(),false,students[i].MobilePhone));
                }
                i+=1;
            }
        
            String jsonReqBody=JSON.serialize(responseretn);
            res.statusCode = 201;
            return jsonReqBody;
            
           
                            
        }
        
    } catch(Exception e) {
        // Handle exceptions
        res.Statuscode = 500;
        return 'Internal Server Error';

        
    }
}
//Response wrapper to return
public class Response{
    public string leadId{get;set;}
    public boolean isSuccess{get;set;}
    public string mobilePhone{get;set;}
    
    public Response(String leadId,Boolean isSuccess,String mobilePhone){
        this.leadId=leadId;
        this.isSuccess=isSuccess;
        this.mobilePhone=mobilePhone;
    }
}

public static Lead setLeadFields(LeadDataDeserializer info){
    Lead extLead=new Lead();
    extLead.LastName=info.Name;
    extLead.CountryCode__c=info.countryCode; 
    extLead.MobilePhone=info.phoneNumber;
    extLead.mx_WhatsApp_Number__c=extLead.MobilePhone;
    extLead.mx_IP_Address__c=info.ipAddress;
    extLead.External_Id__c=extLead.MobilePhone;
    if(info.leadStage!=null){
        extLead.Status=info.leadStage;
    }
    if(info.campaignName!=null){
        extLead.mx_Campaign_Name__c=info.campaignName;
    }
    if(info.campaignSource!=null){
        extLead.SourceCampaign__c=info.campaignSource;
    }

    //20 more if conditions with null check like above (serializeddata.field!=null)
   
    return extLead;
}}

我使用多个 if 语句来仅处理包含具有值的字段，并且如果来自集成的值为空，则不会覆盖先前的记录值

如何有效地处理这个问题？

salesforce