AskOverflow.Dev

AskOverflow.Dev Logo AskOverflow.Dev Logo

AskOverflow.Dev Navigation

  • Início
  • system&network
  • Ubuntu
  • Unix
  • DBA
  • Computer
  • Coding
  • LangChain

Mobile menu

Close
  • Início
  • system&network
    • Recentes
    • Highest score
    • tags
  • Ubuntu
    • Recentes
    • Highest score
    • tags
  • Unix
    • Recentes
    • tags
  • DBA
    • Recentes
    • tags
  • Computer
    • Recentes
    • tags
  • Coding
    • Recentes
    • tags
Início / dba / Perguntas / 340809
Accepted
David Allen
David Allen
Asked: 2024-07-08 23:52:28 +0800 CST2024-07-08 23:52:28 +0800 CST 2024-07-08 23:52:28 +0800 CST

Problemas com desempenho lento do procedimento armazenado em 35 milhões de linhas com tabela CTE/Temp

  • 772

Recentemente, lançamos um novo recurso em nosso aplicativo que adicionou cerca de 25 novas colunas a uma tabela grande (cerca de 35 milhões de linhas) e agora estamos tendo alguns problemas importantes de desempenho de consulta. Presumo que esteja relacionado à enorme quantidade de dados que foram adicionados como parte dessas novas colunas, mas também pode ser baseado em índice, em consulta ou em qualquer outra coisa em que não estou pensando.

Esta tabela contém informações sobre a passagem do crachá junto com informações sobre a pessoa que fez a passagem. Ele reside em um banco de dados AWS RDS e tenho controle total sobre o esquema, mas não sobre a própria instância do RDS. O esquema desta tabela é:


CREATE TABLE [occupancy].[SwipesComplete] (
    [PrimaryObjectID] varchar,
    [ObjectID] int,
    [UserID] varchar, 
    [Name] varchar,
    [PersonnelTypeID] varchar,
    [DoorName] varchar,
    [SwipetimeUTC] datetime,
    [SwipetimeEST] datetime,
    [DoorID] int,
    [SiteID] int,
    [GroupDesc1] varchar,
    [GroupDesc2] varchar,
    [GroupDesc3] varchar,
    [GroupDesc4] varchar,
    [GroupDesc5] varchar,
    [GroupDesc6] varchar,
    [GroupDesc7] varchar,
    [GroupDesc8] varchar,
    [GroupDesc9] varchar,
    [GroupDesc10] varchar,
    [GroupDesc11] varchar,
    [GroupDesc12] varchar,
    [Company] varchar,
    [Site] varchar,
    [Lab_User] int,
    [PersonAssignedBuildingRoomID] varchar,
    [GroupName] varchar,
    [NeighborhoodAssignedSiteCode] varchar,
    [NeighborhoodAssignedSeat] varchar,
    [NeighborhoodName] varchar,
    [PersonnelType] varchar,
    [EmploymentType] varchar,
    [PTFriendlyName] varchar,
    [PersonAssignedBuildingLocID] int,
    [PersonAssignedAreaLocID] int,
    [PersonAssignedFloorLocID] int,
    [LocationCorrelationSourceID] int,
    [SwipeBuildingLocID] int
);

Temos um aplicativo baseado na web que permite aos usuários consultar esses dados e exibir dados agregados em um gráfico com base em um intervalo selecionado pelo usuário (por hora, diariamente, semanalmente, mensalmente, anualmente). Eles podem filtrar quase todas essas colunas.

Existem índices nesta tabela (não os criei e talvez precisem ser modificados):

  • Não exclusivo, não agrupado em PrimaryObjectID e ObjectID
  • Não exclusivo, não agrupado em DoorID e SiteID
  • Não exclusivo, não agrupado no DoorID
  • Não exclusivo, não agrupado em SiteID e SwipetimeUTC
  • Não exclusivo, não agrupado no DoorID
  • Não exclusivo, não agrupado em ObjectID
  • Não exclusivo, não agrupado em SwipetimeEST
  • Não exclusivo, não agrupado em DoorID e SwipetimeUTC
  • Não exclusivo, não agrupado em SwipetimeUTC

Estamos consultando esses dados usando o seguinte procedimento armazenado. Passamos uma matriz JSON para muitos WHEREs porque os usuários podem escolher vários valores para muitos dos filtros. Os usuários também podem optar por agrupar ou não os dados, como você pode ver na instrução CASE. Eu sei que este procedimento armazenado não é ótimo:

CREATE PROCEDURE [occupancy].[GetUniqueOccupancyByRange]        
(
       @StartDate datetime
       ,@EndDate datetime
       ,@Interval nvarchar(20)
       ,@PTFriendlyName VARCHAR(4000)
       ,@SET VARCHAR(4000)
       ,@Function VARCHAR(4000)
       ,@BusinessUnit VARCHAR(4000)
       ,@AssignedSite VARCHAR(4000) -- assigned site
       ,@AssignedLocID VARCHAR(4000) -- assigned building
       ,@NeighborhoodName VARCHAR(4000)
       ,@SwipeLocID VARCHAR(4000)
       ,@SiteID INT
       ,@GroupBy VARCHAR(255)
)  
AS  
  BEGIN  
    if @Interval = 'Hourly'
        BEGIN
            WITH MyCTE AS 
            (
                SELECT ObjectID, DATEPART(year, SwipetimeEST) AS year, DATEPART(month, SwipetimeEST) AS month, DATEPART(week, SwipetimeEST) AS week, DATEPART(day, SwipetimeEST) AS day, DATEPART(hour, SwipetimeEST) AS hour,
                    -- Mapping the @GroupBy options to the respective columns
                    CASE 
                        WHEN @GroupBy = 'None' THEN NULL
                        WHEN @GroupBy = 'Personnel Type' THEN PTFriendlyName
                        WHEN @GroupBy = 'Senior Executive Team' THEN GroupDesc3
                        WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                        WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
                    END AS GroupingClause
                FROM [Database_Server].[occupancy].[SwipesComplete] sc
                LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc
                ON (sc.DoorID = dc.DoorID)
                LEFT JOIN [Join_Database].[site].[LocationInformation] l 
                ON (sc.PersonAssignedBuildingLocID = l.LocID)
                LEFT JOIN [Join_Database].[site].[LocationInformation] loc 
                ON (sc.SwipeBuildingLocID = loc.LocID)
                WHERE sc.SiteID = @SiteID 
                AND SwipetimeUTC BETWEEN @StartDate AND @EndDate
                AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
                AND dc.AssetLocID IS NOT NULL 
                AND dc.AssetLocID != 5
                AND sc.SwipetimeEST IS NOT NULL
                AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
                AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
                AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
                AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
                AND (@PTFriendlyName IS NULL OR  sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
                AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
                AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite))) 
                AND (@SwipeLocID is NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)))
            )
            SELECT COUNT(DISTINCT(ObjectID)) as count, year, month, week, day, hour, GroupingClause AS GroupedBy
            FROM MyCTE
            GROUP BY year, month, week, day, hour, GroupingClause
    END

    if @Interval = 'Daily'
        BEGIN
            WITH MyCTE AS 
                (
                    SELECT ObjectID, DATEPART(year, SwipetimeEST) AS year, DATEPART(month, SwipetimeEST) AS month, DATEPART(week, SwipetimeEST) AS week, DATEPART(day, SwipetimeEST) AS day, 
                        CASE 
                            WHEN @GroupBy = 'None' THEN NULL
                            WHEN @GroupBy = 'Personnel Type' THEN PTFriendlyName
                            WHEN @GroupBy = 'Senior Executive Team' THEN GroupDesc3
                            WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                            WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
                        END AS GroupingClause
                    FROM [Database_Server].[occupancy].[SwipesComplete] sc
                    LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc
                    ON (sc.DoorID = dc.DoorID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] l
                    ON (sc.PersonAssignedBuildingLocID = l.LocID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] loc 
                    ON (sc.SwipeBuildingLocID = loc.LocID)
                    WHERE sc.SiteID = @SiteID 
                    AND SwipetimeUTC BETWEEN @StartDate AND @EndDate
                    AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
                    AND dc.AssetLocID IS NOT NULL 
                    AND dc.AssetLocID != 5
                    AND sc.SwipetimeEST IS NOT NULL
                    AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
                    AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
                    AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
                    AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
                    AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
                    AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
                    AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
                    AND (@SwipeLocID is NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)))
                )
                SELECT COUNT(DISTINCT(ObjectID)) as count, year, month, week, day, GroupingClause as GroupedBy
                FROM MyCTE
                GROUP BY year, month, week, day, GroupingClause
        END

    if @Interval = 'Weekly'
        BEGIN
            WITH MyCTE AS 
                (
                    SELECT ObjectID, DATEPART(year, SwipetimeEST) AS year, DATEPART(week, SwipetimeEST) AS week, 
                        CASE 
                            WHEN @GroupBy = 'None' THEN NULL
                            WHEN @GroupBy = 'Personnel Type' THEN PTFriendlyName
                            WHEN @GroupBy = 'Senior Executive Team' THEN GroupDesc3
                            WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                            WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
                        END AS GroupingClause
                    FROM [Database_Server].[occupancy].[SwipesComplete] sc
                    LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc
                    ON (sc.DoorID = dc.DoorID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] l
                    ON (sc.PersonAssignedBuildingLocID = l.LocID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] loc 
                    ON (sc.SwipeBuildingLocID = loc.LocID)
                    WHERE sc.SiteID = @SiteID 
                    AND SwipetimeUTC BETWEEN @StartDate AND @EndDate
                    AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
                    AND dc.AssetLocID IS NOT NULL 
                    AND dc.AssetLocID != 5
                    AND sc.SwipetimeEST IS NOT NULL
                    AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
                    AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
                    AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
                    AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
                    AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
                    AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
                    AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
                    AND (@SwipeLocID is NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)))
                )
                SELECT COUNT(DISTINCT(ObjectID)) as count, year, week, GroupingClause as GroupedBy
                FROM MyCTE
                GROUP BY year, week, GroupingClause
        END

    if @Interval = 'Monthly'
        BEGIN
            WITH MyCTE AS 
                (
                    SELECT ObjectID, DATEPART(year, SwipetimeEST) AS year, DATEPART(month, SwipetimeEST) AS month, 
                        CASE 
                            WHEN @GroupBy = 'None' THEN NULL
                            WHEN @GroupBy = 'Personnel Type' THEN PTFriendlyName
                            WHEN @GroupBy = 'Senior Executive Team' THEN GroupDesc3
                            WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                            WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
                        END AS GroupingClause
                    FROM [Database_Server].[occupancy].[SwipesComplete] sc
                    LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc
                    ON (sc.DoorID = dc.DoorID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] l
                    ON (sc.PersonAssignedBuildingLocID = l.LocID)
                    LEFT JOIN [Join_Database].[site].[LocationInformation] loc 
                    ON (sc.SwipeBuildingLocID = loc.LocID)
                    WHERE sc.SiteID = @SiteID 
                    AND SwipetimeUTC BETWEEN @StartDate AND @EndDate
                    AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
                    AND dc.AssetLocID IS NOT NULL 
                    AND dc.AssetLocID != 5
                    AND sc.SwipetimeEST IS NOT NULL
                    AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
                    AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
                    AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
                    AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
                    AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
                    AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
                    AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
                    AND (@SwipeLocID is NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)))
                )
                SELECT COUNT(DISTINCT(ObjectID)) as count, year, month, GroupingClause AS GroupedBy
                FROM MyCTE
                GROUP BY year, month, GroupingClause
        END

    if @Interval = 'Yearly'
       BEGIN
        WITH MyCTE AS 
            (
                SELECT ObjectID, DATEPART(year, SwipetimeEST) AS year, 
                    CASE 
                        WHEN @GroupBy = 'None' THEN NULL
                        WHEN @GroupBy = 'Personnel Type' THEN PTFriendlyName
                        WHEN @GroupBy = 'Senior Executive Team' THEN GroupDesc3
                        WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                        WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
                    END AS GroupingClause
                FROM [Database_Server].[occupancy].[SwipesComplete] sc
                LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc
                ON (sc.DoorID = dc.DoorID)
                LEFT JOIN [Join_Database].[site].[LocationInformation] l
                ON (sc.PersonAssignedBuildingLocID = l.LocID)
                LEFT JOIN [Join_Database].[site].[LocationInformation] loc 
                ON (sc.SwipeBuildingLocID = loc.LocID)
                WHERE sc.SiteID = @SiteID 
                AND SwipetimeUTC BETWEEN @StartDate AND @EndDate
                AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
                AND dc.AssetLocID IS NOT NULL 
                AND dc.AssetLocID != 5
                AND sc.SwipetimeEST IS NOT NULL
                AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
                AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
                AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
                AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
                AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
                AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
                AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
                AND (@SwipeLocID is NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)))
            )
            SELECT COUNT(DISTINCT(ObjectID)) as count, year, GroupingClause AS GroupedBy
            FROM MyCTE
            GROUP BY year, GroupingClause
    END
  END
GO

Estamos tendo alguns problemas importantes de desempenho em que o procedimento armazenado levará mais de um minuto para retornar 12 meses de dados em um intervalo semanal ou tempos de carregamento de 15 a 20 segundos para 1 mês de dados diários.

Aqui estão algumas coisas que tentei:

  • Armazenar em cache as partes da data da consulta diretamente na tabela para que não precisem ser calculadas todas as vezes
  • Dividir a tabela em duas tabelas, uma para os dados dos últimos 12 meses e outra para todo o resto. Isso ocorre porque supõe-se que a maioria das pessoas analisará os dados apenas dos últimos meses; portanto, se pudermos proporcionar-lhes uma experiência melhor, prefiro fazer isso.

Com essas mudanças estou vendo uma melhora, mas não é suficiente e não sei para onde ir a partir daqui. Para o esquema, adicionei colunas INT de ano, mês, dia, semana, hora e atualizei todos os dados existentes com suas partes de dados correspondentes. E como mencionei, divido os dados em duas tabelas ( SwipesComplete(rolando 12 meses) e SwipesCompleteArchive(> 12 meses))

Aqui está o procedimento armazenado atualizado:

CREATE OR ALTER PROCEDURE [occupancy].[FIDBGetUniqueOccupancyByRange] (
    @StartDate datetime,
    @EndDate datetime,
    @Interval nvarchar(20),
    @PTFriendlyName VARCHAR(4000),
    @SET VARCHAR(4000),
    @Function VARCHAR(4000),
    @BusinessUnit VARCHAR(4000),
    @AssignedSite VARCHAR(4000), -- assigned site
    @AssignedLocID VARCHAR(4000), -- assigned building
    @NeighborhoodName VARCHAR(4000),
    @SwipeLocID VARCHAR(4000),
    @SiteID INT,
    @GroupBy VARCHAR(255)
) 
AS 
BEGIN 
    CREATE TABLE #TempTable (
        ObjectID INT,
        year INT,
        month INT,
        week INT,
        day INT,
        hour INT,
        GroupingClause VARCHAR(4000)
    );

    INSERT INTO #TempTable (ObjectID, year, month, week, day, hour, GroupingClause)
    SELECT
        sc.ObjectID,
        sc.year,
        sc.month,
        sc.week,
        sc.day,
        sc.hour,
        CASE
            WHEN @GroupBy = 'None' THEN NULL
            WHEN @GroupBy = 'Personnel Type' THEN sc.PTFriendlyName
            WHEN @GroupBy = 'Senior Executive Team' THEN sc.GroupDesc3
            WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
            WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
        END AS GroupingClause
    FROM
        [Database_Server].[occupancy].[SwipesComplete] sc
        LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc ON (sc.DoorID = dc.DoorID)
        LEFT JOIN [Join_Database].[site].[LocationInformation] l ON (sc.PersonAssignedBuildingLocID = l.LocID)
        LEFT JOIN [Join_Database].[site].[LocationInformation] loc ON (sc.SwipeBuildingLocID = loc.LocID)
    WHERE
        sc.SiteID = @SiteID
        AND sc.SwipetimeUTC BETWEEN @StartDate AND @EndDate
        AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
        AND dc.AssetLocID IS NOT NULL AND dc.AssetLocID != 5
        AND sc.SwipetimeEST IS NOT NULL
        AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
        AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
        AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
        AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
        AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
        AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
        AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
        AND (@SwipeLocID IS NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)));

    IF @StartDate <= DATEADD(year, -1, GETDATE())
    BEGIN
        INSERT INTO #TempTable (ObjectID, year, month, week, day, hour, GroupingClause)
        SELECT
            sc.ObjectID,
            sc.year,
            sc.month,
            sc.week,
            sc.day,
            sc.hour,
            CASE
                WHEN @GroupBy = 'None' THEN NULL
                WHEN @GroupBy = 'Personnel Type' THEN sc.PTFriendlyName
                WHEN @GroupBy = 'Senior Executive Team' THEN sc.GroupDesc3
                WHEN @GroupBy = 'Assigned Building' THEN l.BuildingLocName
                WHEN @GroupBy = 'Swipes by Building' THEN loc.BuildingLocName
            END AS GroupingClause
        FROM
            [Database_Server].[occupancy].[SwipesCompleteArchive] sc
            LEFT JOIN [Database_Server].[occupancy].[DoorsComplete] dc ON (sc.DoorID = dc.DoorID)
            LEFT JOIN [Join_Database].[site].[LocationInformation] l ON (sc.PersonAssignedBuildingLocID = l.LocID)
            LEFT JOIN [Join_Database].[site].[LocationInformation] loc ON (sc.SwipeBuildingLocID = loc.LocID)
        WHERE
            sc.SiteID = @SiteID
            AND sc.SwipetimeUTC BETWEEN @StartDate AND @EndDate
            AND (sc.Name IS NULL OR sc.Name NOT LIKE '%Visitor%')
            AND dc.AssetLocID IS NOT NULL AND dc.AssetLocID != 5
            AND sc.SwipetimeEST IS NOT NULL
            AND (@NeighborhoodName IS NULL OR sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))
            AND (@SET IS NULL OR sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET)))
            AND (@Function IS NULL OR sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function)))
            AND (@BusinessUnit IS NULL OR sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit)))
            AND (@PTFriendlyName IS NULL OR sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName)))
            AND (@AssignedLocID IS NULL OR sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID)))
            AND (@AssignedSite IS NULL OR sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))
            AND (@SwipeLocID IS NULL OR sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID)));
    END

    IF @Interval = 'Hourly' 
    BEGIN
        SELECT 
            COUNT(DISTINCT(ObjectID)) AS count,
            year,
            month,
            week,
            day,
            hour,
            GroupingClause AS GroupedBy
        FROM #TempTable
        GROUP BY year, month, week, day, hour, GroupingClause;
    END
    ELSE IF @Interval = 'Daily' 
    BEGIN
        SELECT 
            COUNT(DISTINCT(ObjectID)) AS count,
            year,
            month,
            week,
            day,
            GroupingClause AS GroupedBy
        FROM #TempTable
        GROUP BY year, month, week, day, GroupingClause;
    END
    ELSE IF @Interval = 'Weekly' 
    BEGIN
        SELECT 
            COUNT(DISTINCT(ObjectID)) AS count,
            year,
            week,
            GroupingClause AS GroupedBy
        FROM #TempTable
        GROUP BY year, week, GroupingClause;
    END
    ELSE IF @Interval = 'Monthly' 
    BEGIN
        SELECT 
            COUNT(DISTINCT(ObjectID)) AS count,
            year,
            month,
            GroupingClause AS GroupedBy
        FROM #TempTable
        GROUP BY year, month, GroupingClause;
    END
    ELSE IF @Interval = 'Yearly' 
    BEGIN
        SELECT 
            COUNT(DISTINCT(ObjectID)) AS count,
            year,
            GroupingClause AS GroupedBy
        FROM #TempTable
        GROUP BY year, GroupingClause;
    END

    DROP TABLE #TempTable;
END

Where do I go from here? In splitting the data into multiple tables actually going to help? Is there a way to query what I want without needing to use a temp table or a CTE? If a user wants to query 12 months of data, it's going to insert ~6 million rows into the temp table if they have no additional filters, which is a ton. I'm at a loss for how to make this performant enough.

I'm willing to change up the schema if I have to, but I'd love to find a way to solve this with some index changes or query changes. At this point anything will help.

sql-server
  • 1 1 respostas
  • 72 Views

1 respostas

  • Voted
  1. Best Answer
    Charlieface
    2024-07-10T00:00:47+08:002024-07-10T00:00:47+08:00

    This is a classic Kitchen Sink Query. While you could add OPTION (RECOMPILE) as a quick fix, this comes at a cost of recompiling on every run.

    Instead, you should build a dynamic query. Don't forget to properly parameterize the dynamic query.

    CREATE OR ALTER PROCEDURE [occupancy].[GetUniqueOccupancyByRange]        
    (
           @StartDate datetime
           ,@EndDate datetime
           ,@Interval nvarchar(20)
           ,@PTFriendlyName NVARCHAR(MAX)
           ,@SET NVARCHAR(MAX)
           ,@Function NVARCHAR(MAX)
           ,@BusinessUnit NVARCHAR(MAX)
           ,@AssignedSite NVARCHAR(MAX) -- assigned site
           ,@AssignedLocID NVARCHAR(MAX) -- assigned building
           ,@NeighborhoodName NVARCHAR(MAX)
           ,@SwipeLocID NVARCHAR(MAX)
           ,@SiteID INT
           ,@GroupBy VARCHAR(255)
    )  
    AS  
    
    DECLARE @sql nvarchar(max), @groupByCols nvarchar(max);
    
    SET @groupByCols = CONCAT_WS(N',
    ',
        N'year',
        CASE WHEN @Interval IN ('Daily', 'Monthly', 'Hourly') THEN N'month' END,
        CASE WHEN @Interval IN ('Daily', 'Weekly', 'Hourly') THEN N'week' END,
        CASE WHEN @Interval IN ('Daily', 'Weekly', 'Monthly', 'Hourly') THEN N'day' END,
        CASE WHEN @Interval IN ('Daily', 'Weekly', 'Monthly', 'Hourly') THEN N'hour' END,
        CASE @GroupBy
            WHEN 'Personnel Type' THEN N'PTFriendlyName'
            WHEN 'Senior Executive Team' THEN N'GroupDesc3'
            WHEN 'Assigned Building' THEN N'l.BuildingLocName'
            WHEN 'Swipes by Building' THEN N'loc.BuildingLocName'
        END
      );
    
    SET @sql = N'
    WITH MyCTE AS 
    (
        SELECT
          ObjectID,    -- compiler will remove unnecessary columns
          DATEPART(year, sc.SwipetimeEST) AS year,
          DATEPART(month, sc.SwipetimeEST) AS month,
          DATEPART(week, sc.SwipetimeEST) AS week,
          DATEPART(day, sc.SwipetimeEST) AS day,
          DATEPART(hour, sc.SwipetimeEST) AS hour,
          PTFriendlyName,
          GroupDesc3,
          l.BuildingLocName,
          loc.BuildingLocName
        FROM Database_Server.occupancy.SwipesComplete sc
        JOIN Database_Server.occupancy.DoorsComplete dc ON sc.DoorID = dc.DoorID
        LEFT JOIN Join_Database.site.LocationInformation l ON sc.PersonAssignedBuildingLocID = l.LocID
        LEFT JOIN Join_Database.site.LocationInformation loc ON sc.SwipeBuildingLocID = loc.LocID
        WHERE sc.SiteID = @SiteID 
          AND sc.SwipetimeUTC BETWEEN @StartDate AND @EndDate
          AND (sc.Name IS NULL OR sc.Name NOT LIKE ''%Visitor%'')
          AND dc.AssetLocID IS NOT NULL 
          AND dc.AssetLocID != 5
          AND sc.SwipetimeEST IS NOT NULL
    ';
    
    IF @NeighborhoodName IS NOT NULL
        SET @sql += N'
          AND sc.NeighborhoodName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@NeighborhoodName)))';
    
    IF @SET IS NOT NULL
        SET @sql += N'
          AND sc.GroupDesc3 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SET))';
    
    IF @Function IS NOT NULL
        SET @sql += N'
          AND sc.GroupDesc4 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@Function))';
    
    IF @BusinessUnit IS NOT NULL
        SET @sql += N'
          sc.GroupDesc5 IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@BusinessUnit))';
    
    IF @PTFriendlyName IS NOT NULL
        SET @sql += N'
          AND sc.PTFriendlyName IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@PTFriendlyName))';
    
    IF @AssignedLocID IS NOT NULL
        SET @sql += N'
          AND sc.PersonAssignedBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedLocID))';
    
    IF @AssignedSite IS NOT NULL
        SET @sql += N'
          AND sc.Site IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@AssignedSite)))';
    
    IF @SwipeLocID IS NOT NULL
        SET @sql += N'
          AND sc.SwipeBuildingLocID IN (SELECT value COLLATE SQL_Latin1_General_CP1_CI_AS FROM OPENJSON(@SwipeLocID))';
    
    SET @sql += N'
    )
    SELECT
      COUNT(DISTINCT(cte.ObjectID)) as count,
    ' + @groupByCols + N'
    FROM MyCTE cte
    GROUP BY
      ' + @groupByCols;
    
    
    PRINT @sql;    -- your friend
    
    EXEC sp_executesql @sql,
    
          N'@StartDate datetime
           ,@EndDate datetime
           ,@PTFriendlyName NVARCHAR(MAX)
           ,@SET NVARCHAR(MAX)
           ,@Function NVARCHAR(MAX)
           ,@BusinessUnit NVARCHAR(MAX)
           ,@AssignedSite NVARCHAR(MAX) -- assigned site
           ,@AssignedLocID NVARCHAR(MAX) -- assigned building
           ,@NeighborhoodName NVARCHAR(MAX)
           ,@SwipeLocID NVARCHAR(MAX)
           ,@SiteID INT',
    
            @StartDate = @StartDate,
            @EndDate = @EndDate,
            @PTFriendlyName = @PTFriendlyName,
            @SET = @SET,
            @Function = @Function,
            @BusinessUnit = @BusinessUnit,
            @AssignedSite = @AssignedSite,
            @AssignedLocID = @AssignedLocID,
            @NeighborhoodName = @NeighborhoodName,
            @SwipeLocID = @SwipeLocID,
            @SiteID = @SiteID;
    

    Further notes:

    • The JSONs should be typed as nvarchar(max).
    • I strongly suggest you change the JSONs into Table Valued Parameters (with inline primary keys) for better peformance.
    • You should also add/remove joins conditionally if possible. I don't know your schema and intended results so I haven't done that, it's also hard to see what's going on when half the columns don't have table aliases.
    • Possibly some or all of those joins should actually be EXISTS, and then you don't need COUNT(DISTINCT and it can just be a more efficient COUNT(*).
    • 3

relate perguntas

  • SQL Server - Como as páginas de dados são armazenadas ao usar um índice clusterizado

  • Preciso de índices separados para cada tipo de consulta ou um índice de várias colunas funcionará?

  • Quando devo usar uma restrição exclusiva em vez de um índice exclusivo?

  • Quais são as principais causas de deadlocks e podem ser evitadas?

  • Como determinar se um Índice é necessário ou necessário

Sidebar

Stats

  • Perguntas 205573
  • respostas 270741
  • best respostas 135370
  • utilizador 68524
  • Highest score
  • respostas
  • Marko Smith

    conectar ao servidor PostgreSQL: FATAL: nenhuma entrada pg_hba.conf para o host

    • 12 respostas
  • Marko Smith

    Como fazer a saída do sqlplus aparecer em uma linha?

    • 3 respostas
  • Marko Smith

    Selecione qual tem data máxima ou data mais recente

    • 3 respostas
  • Marko Smith

    Como faço para listar todos os esquemas no PostgreSQL?

    • 4 respostas
  • Marko Smith

    Listar todas as colunas de uma tabela especificada

    • 5 respostas
  • Marko Smith

    Como usar o sqlplus para se conectar a um banco de dados Oracle localizado em outro host sem modificar meu próprio tnsnames.ora

    • 4 respostas
  • Marko Smith

    Como você mysqldump tabela (s) específica (s)?

    • 4 respostas
  • Marko Smith

    Listar os privilégios do banco de dados usando o psql

    • 10 respostas
  • Marko Smith

    Como inserir valores em uma tabela de uma consulta de seleção no PostgreSQL?

    • 4 respostas
  • Marko Smith

    Como faço para listar todos os bancos de dados e tabelas usando o psql?

    • 7 respostas
  • Martin Hope
    Jin conectar ao servidor PostgreSQL: FATAL: nenhuma entrada pg_hba.conf para o host 2014-12-02 02:54:58 +0800 CST
  • Martin Hope
    Stéphane Como faço para listar todos os esquemas no PostgreSQL? 2013-04-16 11:19:16 +0800 CST
  • Martin Hope
    Mike Walsh Por que o log de transações continua crescendo ou fica sem espaço? 2012-12-05 18:11:22 +0800 CST
  • Martin Hope
    Stephane Rolland Listar todas as colunas de uma tabela especificada 2012-08-14 04:44:44 +0800 CST
  • Martin Hope
    haxney O MySQL pode realizar consultas razoavelmente em bilhões de linhas? 2012-07-03 11:36:13 +0800 CST
  • Martin Hope
    qazwsx Como posso monitorar o andamento de uma importação de um arquivo .sql grande? 2012-05-03 08:54:41 +0800 CST
  • Martin Hope
    markdorison Como você mysqldump tabela (s) específica (s)? 2011-12-17 12:39:37 +0800 CST
  • Martin Hope
    Jonas Como posso cronometrar consultas SQL usando psql? 2011-06-04 02:22:54 +0800 CST
  • Martin Hope
    Jonas Como inserir valores em uma tabela de uma consulta de seleção no PostgreSQL? 2011-05-28 00:33:05 +0800 CST
  • Martin Hope
    Jonas Como faço para listar todos os bancos de dados e tabelas usando o psql? 2011-02-18 00:45:49 +0800 CST

Hot tag

sql-server mysql postgresql sql-server-2014 sql-server-2016 oracle sql-server-2008 database-design query-performance sql-server-2017

Explore

  • Início
  • Perguntas
    • Recentes
    • Highest score
  • tag
  • help

Footer

AskOverflow.Dev

About Us

  • About Us
  • Contact Us

Legal Stuff

  • Privacy Policy

Language

  • Pt
  • Server
  • Unix

© 2023 AskOverflow.DEV All Rights Reserve